jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OAK-6637) Release IndexNode lock in finally clause
Date Fri, 08 Sep 2017 08:51:00 GMT
Chetan Mehrotra created OAK-6637:
------------------------------------

             Summary: Release IndexNode lock in finally clause
                 Key: OAK-6637
                 URL: https://issues.apache.org/jira/browse/OAK-6637
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: lucene
            Reporter: Chetan Mehrotra
            Assignee: Chetan Mehrotra
            Priority: Minor
             Fix For: 1.8


IndexNode currently makes 2 call in release

{code}
        @Override
        public void release() {
            if (released.compareAndSet(false, true)) {
                //Decrement on each release
                decrementSearcherUsageCount(holder.searcher);
                IndexNodeManager.this.release();
            }
        }
{code}

Its possible that decrementSearcherUsageCount can throw exception and in that case lock would
not be released leading to situation as seen in OAK-6619. 

As a fix the lock should be released in finally



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message