jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability
Date Thu, 21 Sep 2017 06:47:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174343#comment-16174343

Alex Deparvu commented on OAK-6662:

bq. i think we need more tests reflecting the behavior when multiple impls are present
I fully agree. wanted to get some early feedback for the patch to make sure it's looking ok

bq. i am not totally sure if the composite shouldn't have the SimpleCredentialsSupport included
as well for compatibility reasons
hmm. it might be the other way around though. If you add this in _by default_ there's a test
failing ( {{TokenConfigurationImplOSGiTest}} hinting at the expected behavior that there should
be no fallback if there's a wired config. But it might be the case that we need to rewrite
the test :) 

Another example where I'm not clear on what the {{CompositeCredentialsSupport}} should do
is the attributes handling. should the composite filter out implementations that can't explicitly
handle that class, or should it delegate either way and leave it to each implementation to
ignore credentials it can't handle. MY preference would be the latter, but the test I mentioned
earlier throws exceptions in this case.

re. the example you posted, I'll start working on a dedicated test.

> Extend CredentialsSupport pluggability
> --------------------------------------
>                 Key: OAK-6662
>                 URL: https://issues.apache.org/jira/browse/OAK-6662
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Antonio Sanso
> At the moment the {{TokenConfigurationImpl}} binds a {{ReferenceCardinality.OPTIONAL_UNARY}}
for {{CredentialsSupport}}.
> It would be useful to extend the support to {{OPTIONAL_MULTIPLE}} in order to cover more
generic cases.
> cc [~anchela]

This message was sent by Atlassian JIRA

View raw message