jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability
Date Thu, 21 Sep 2017 07:05:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174355#comment-16174355

angela commented on OAK-6662:

[~stillalex], without having looked at {{TokenConfigurationImplOSGiTest}} again, I would say
that the test needs to be adjusted because it has been built under the assumption that the
{{CredentialsSupport}} is unary. Regarding your second question: if the composite needs to
filter it out, we probably should add a method to {{CredentialsSupport}} that allows the composite
to determine if a given implementation of {{Credentials}} is being supported in order to prevent
it to do the comparison from the {{getCredentialClasses}}, which returns a {{Set}}. If we
go for the latter we should probably explicitly mention it in the API contract that the impl
must not fail if the credentials are not supported (-> and fix the test-implementation
accordingly)... the API contract today already allows for ignoring or returning {{null}}...
so we might be good and just needed to make it a bit more explicit. 

> Extend CredentialsSupport pluggability
> --------------------------------------
>                 Key: OAK-6662
>                 URL: https://issues.apache.org/jira/browse/OAK-6662
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Antonio Sanso
> At the moment the {{TokenConfigurationImpl}} binds a {{ReferenceCardinality.OPTIONAL_UNARY}}
for {{CredentialsSupport}}.
> It would be useful to extend the support to {{OPTIONAL_MULTIPLE}} in order to cover more
generic cases.
> cc [~anchela]

This message was sent by Atlassian JIRA

View raw message