jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francesco Mari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6667) Refactor StandbyDiff for better clarity and understandability
Date Wed, 20 Sep 2017 07:51:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172870#comment-16172870
] 

Francesco Mari commented on OAK-6667:
-------------------------------------

[~dulceanu], the patch looks good to me.

> Refactor StandbyDiff for better clarity and understandability
> -------------------------------------------------------------
>
>                 Key: OAK-6667
>                 URL: https://issues.apache.org/jira/browse/OAK-6667
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar, tarmk-standby
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: cold-standby
>             Fix For: 1.7.8
>
>         Attachments: OAK-6667.patch
>
>
> {{StandbyDiff}} still makes use of the {{logOnly}} property for deciding when to act
upon node/property changes. The official documentation of {{logOnly}} states that it helps
for
> {quote}
> /**
>      * read-only traversal of the diff that has 2 properties: one is to log all
>      * the content changes, second is to drill down to properly level, so that
>      * missing binaries can be sync'ed if needed
>      */
> {quote}
> but it's use is a bit misleading. The first call to {{StandbyDiff}} is always with {{logOnly==false}},
while subsequent calls are done with {{logOnly==true}}. Implementing {{StandbyDiff}} without
this mechanism would result in better clarity and maintainability.
> Another minor improvement is to rename {{#binaryCheck}} methods and {{#readBinary}} to
{{#fetchBinary}} and {{#fetchAndStoreBlob}} which is more appropriate to their purpose.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message