jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6686) Move OakVersion to oak-commons
Date Wed, 20 Sep 2017 16:00:17 GMT

    [ https://issues.apache.org/jira/browse/OAK-6686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173404#comment-16173404

Alex Deparvu commented on OAK-6686:

patch looks good, +1.
I would even mark it as deprecated, to be removed in a future release, as there's not much
use for it anyways (the {{ContentRepositoryImpl}} class could also start using the commons
version too).

bq. In a separate/next step, the DocumentNodeStore dependency on the oak-core OakVersion class
can be replaced with the one in oak-commons.
makes sense. I would assume this will in turn report it's own bundle's version, not {{oak-core}}'s.

> Move OakVersion to oak-commons
> ------------------------------
>                 Key: OAK-6686
>                 URL: https://issues.apache.org/jira/browse/OAK-6686
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: commons, core
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.8
>         Attachments: OAK-6686.patch
> The class {{OakVersion}} currently lives in oak-core and is used by the DocumentNodeStore
to print the version when initialized. The version utility should be moved to oak-commons
and made more generic. It is currently only possible to get the version of the oak-core module.

This message was sent by Atlassian JIRA

View raw message