jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6690) Refactor constants classes NodeTypeConstants, NamespaceConstants, VersionConstants
Date Wed, 20 Sep 2017 15:49:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173379#comment-16173379
] 

Alex Deparvu commented on OAK-6690:
-----------------------------------

I've extracted the specific bits from [~anchela]'s patch over at OAK-6318 on a dedicated branch
[0].
The solution is a bit awkward but still ok compared to alternatives (same for all 3 classes):
* moved {{NodeTypeConstants}} from {{oak-core}} to a _new_ package {{org.apache.jackrabbit.oak.spi.nodetype}}
in {{oak-core-spi}}.
* moved {{NamespaceConstants}} from {{oak-core}} to a _new_ package {{org.apache.jackrabbit.oak.spi.namespace}}
in {{oak-core-spi}}.
* moved {{VersionConstants}} from {{oak-core}} to a _new_ package {{org.apache.jackrabbit.oak.spi.version}}
in {{oak-core-spi}}.
* {{oak-core-spi}} now exports all three new packages.

[~mreutegg] would like to have your feedback on this as well.
[~anchela] please double check if I missed something while cherry picking the commits
anyone else is welcome to join the feedback party

[0] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:oak-6318-constants

> Refactor constants classes NodeTypeConstants, NamespaceConstants, VersionConstants
> ----------------------------------------------------------------------------------
>
>                 Key: OAK-6690
>                 URL: https://issues.apache.org/jira/browse/OAK-6690
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, core-spi
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>
> The {{NodeTypeConstants}}, {{NamespaceConstants}}, {{VersionConstants}} classes would
need to be refactored (probably moved) due to the high number of dependencies on them from
various packages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message