jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6690) Refactor constants classes NodeTypeConstants, NamespaceConstants, VersionConstants
Date Thu, 21 Sep 2017 08:29:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174434#comment-16174434
] 

Marcel Reutegger commented on OAK-6690:
---------------------------------------

Looks good to me. The only alternative that I can come up with is to move the interfaces to
oak-commons. Similar to how JcrConstants is part of jackrabbit-jcr-commons. But then some
of those constants are rather implementation detail and should probably not go into oak-commons.
We could also move some of the constant fields to JcrConstants. At least those that are not
Oak specific. But I'm not sure if that's worth it.

> Refactor constants classes NodeTypeConstants, NamespaceConstants, VersionConstants
> ----------------------------------------------------------------------------------
>
>                 Key: OAK-6690
>                 URL: https://issues.apache.org/jira/browse/OAK-6690
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, core-spi
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>
> The {{NodeTypeConstants}}, {{NamespaceConstants}}, {{VersionConstants}} classes would
need to be refactored (probably moved) due to the high number of dependencies on them from
various packages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message