jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6711) Refactor IndexConstants so it can be referenced from outside oak-core
Date Wed, 27 Sep 2017 12:13:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182458#comment-16182458
] 

Thomas Mueller commented on OAK-6711:
-------------------------------------

As for the security code, is the problem just PermissionValidator?

{noformat}
    private boolean isIndexDefinition(@Nonnull Tree tree) {
        return tree.getPath().contains(IndexConstants.INDEX_DEFINITIONS_NAME);
    }
{noformat}

If yes, then what about splitting IndexConstants to "public" and "internal". Because most
of IndexConstants is only used in oak-core, and oak-lucene. So still both could end up in
(for example) oak-query-spi right now, but usage is different.

> Refactor IndexConstants so it can be referenced from outside oak-core
> ---------------------------------------------------------------------
>
>                 Key: OAK-6711
>                 URL: https://issues.apache.org/jira/browse/OAK-6711
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>             Fix For: 1.7.9
>
>
> This is blocking OAK-6318, the security spi code depends on this constants class so I'd
like to move it to a different location.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message