jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-7694) Oak.OakDefaultComponents.INSTANCE is mutable
Date Wed, 08 Aug 2018 16:22:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573444#comment-16573444
] 

Marcel Reutegger commented on OAK-7694:
---------------------------------------

Proposed fix: https://github.com/apache/jackrabbit-oak/compare/trunk...mreutegg:OAK-7694

[~stillalex], WDYT?

> Oak.OakDefaultComponents.INSTANCE is mutable
> --------------------------------------------
>
>                 Key: OAK-7694
>                 URL: https://issues.apache.org/jira/browse/OAK-7694
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.8.0
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.10
>
>
> The {{OakDefaultComponents}} inside the {{Oak}} builder class was introduced with OAK-6826
and provides a set of default components. Those components can be overridden by calling the
various {{Oak.with()}} methods.
> There is a problematic {{OakDefaultComponents}} singleton {{INSTANCE}} used by {{Jcr}}.
The singleton is mutable and may leak modifications from one {{Jcr}} instantiation to another
one. More specifically, the {{SecurityProvider}} has a couple of configurations that extend
{{ConfigurationBase}} with multiple setters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message