jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amit Jain (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OAK-7724) BlobGCMbean not registered with SegmentNodeStoreFactory
Date Fri, 31 Aug 2018 08:26:00 GMT
Amit Jain created OAK-7724:

             Summary: BlobGCMbean not registered with SegmentNodeStoreFactory
                 Key: OAK-7724
                 URL: https://issues.apache.org/jira/browse/OAK-7724
             Project: Jackrabbit Oak
          Issue Type: Bug
          Components: segment-tar
            Reporter: Amit Jain
             Fix For: 1.10

SegmentNodeStoreService checks to see if the segment store is primary before registering the

With SegmentNodeStoreFactory the Configuration#isPrimarySegmentStore is always set to false.
The intention is to not register the BlobGC when the the role is secondary in which case the
condition should be changed to

IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
--- oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreRegistrar.java
(revision 9f1e8bdc6c91ba750ac1eea540fe59ac89ef9114)
+++ oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreRegistrar.java
(date 1535703785000)
@@ -397,7 +397,7 @@
- if (cfg.isPrimarySegmentStore() && cfg.getBlobStore() instanceof GarbageCollectableBlobStore)
+ if (!cfg.isSecondarySegmentStore() && cfg.getBlobStore() instanceof GarbageCollectableBlobStore)
 BlobGarbageCollector gc = new MarkSweepGarbageCollector(
 new SegmentBlobReferenceRetriever(store),
 (GarbageCollectableBlobStore) cfg.getBlobStore(),


This message was sent by Atlassian JIRA

View raw message