jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomek Rękawek (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-7724) BlobGCMbean not registered with SegmentNodeStoreFactory
Date Fri, 31 Aug 2018 09:45:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598499#comment-16598499
] 

Tomek Rękawek commented on OAK-7724:
------------------------------------

OK, so in the composite node store, even the global, mutable segment node store is registered
with the role, so the blob GC is disabled for it.

We need this patch to enable the blob GC for the global segment node store in the composite
setup.

Patch LGTM!

> BlobGCMbean not registered with SegmentNodeStoreFactory
> -------------------------------------------------------
>
>                 Key: OAK-7724
>                 URL: https://issues.apache.org/jira/browse/OAK-7724
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Amit Jain
>            Assignee: Amit Jain
>            Priority: Major
>             Fix For: 1.10
>
>         Attachments: OAK-7724.patch
>
>
> SegmentNodeStoreService checks to see if the segment store is primary before registering
the BlobGCMbean. 
> With SegmentNodeStoreFactory the Configuration#isPrimarySegmentStore is always set to
false. The intention is to not register the BlobGC when the the role is secondary in which
case the condition should be changed to
> {code}
> ckrabbit/oak/segment/SegmentNodeStoreRegistrar.java
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> --- oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreRegistrar.java
(revision 9f1e8bdc6c91ba750ac1eea540fe59ac89ef9114)
> +++ oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreRegistrar.java
(date 1535703785000)
> @@ -397,7 +397,7 @@
>  }
>  }
>  
> - if (cfg.isPrimarySegmentStore() && cfg.getBlobStore() instanceof GarbageCollectableBlobStore)
{
> + if (!cfg.isSecondarySegmentStore() && cfg.getBlobStore() instanceof GarbageCollectableBlobStore)
{
>  BlobGarbageCollector gc = new MarkSweepGarbageCollector(
>  new SegmentBlobReferenceRetriever(store),
>  (GarbageCollectableBlobStore) cfg.getBlobStore(),
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message