jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Angela Schreiber (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (OAK-9514) Add RestrictionPattern.matches(@NotNull String path, boolean isProperty)
Date Thu, 12 Aug 2021 12:38:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388036#comment-17388036
] 

Angela Schreiber edited comment on OAK-9514 at 8/12/21, 12:37 PM:
------------------------------------------------------------------

rev. eda02347fc..65ef6569aa
rev. 95a176b27f..2c26285706  (missing tests in _oak-security-spi_)


was (Author: anchela):
rev. eda02347fc..65ef6569aa

> Add RestrictionPattern.matches(@NotNull String path, boolean isProperty)
> ------------------------------------------------------------------------
>
>                 Key: OAK-9514
>                 URL: https://issues.apache.org/jira/browse/OAK-9514
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security-spi
>            Reporter: Angela Schreiber
>            Assignee: Angela Schreiber
>            Priority: Major
>             Fix For: 1.42.0
>
>
> the existing method {{RestrictionPattern.matches(@NotNull String path}} doesn't allow
to indicate to the restriction evaluation if the path points to a node or property. while
this makes sense for cases where the nature of the target item is not known, there are usages
of the method throughout oak where the type of the target item is known (e.g. evaluations
for a parent path). for those case it would be preferrable to call {{RestrictionPattern.matches(@NotNull
String path, boolean isProperty)}}.
> For backwards compatibility the new method should come with a default e.g. falling back
to {{RestrictionPattern.matches(@NotNull String path}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message