jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Angela Schreiber (Jira)" <j...@apache.org>
Subject [jira] [Created] (OAK-9543) AbstractServiceTracker: add protected constructor with filter properties
Date Fri, 20 Aug 2021 09:52:00 GMT
Angela Schreiber created OAK-9543:
-------------------------------------

             Summary: AbstractServiceTracker: add protected constructor with filter properties
                 Key: OAK-9543
                 URL: https://issues.apache.org/jira/browse/OAK-9543
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: core-spi
            Reporter: Angela Schreiber
            Assignee: Angela Schreiber


the {{Whiteboard}} has to variants on how to track services:
- track(Class<T> type)
- track(Class<T> type, Map<String, String> filterProperties)

however, the second variant is not reflected in the {{AbstractServiceTracker}} and thus calling
{{AbstractServiceTracker.start(Whiteboard whiteboard)}} will currently always call {{Whiteboard.track(Class)}}.

i would therefore suggest to introduce a second constructor for {{AbstractServiceTracker}}:
 
{code}
protected AbstractServiceTracker(@NotNull Class<T> type, @NotNull Map<String, String>
filterProperties)
{code}

subsequently, {{AbstractServiceTracker.start(Whiteboard whiteboard)}} would call {{Whiteboard.track(Class<T>
type, Map<String, String> filterProperties)}} if the tracker has been created a with
dedicated filter property map.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message