jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-947: Properly configure live tests in ProfitBricks (#222)
Date Thu, 12 Nov 2015 22:05:54 GMT
Awesome work here @devcsrj! I like the proposed changes in the tests, and also the code cleanup
in the compute predicates. Both are changes in the right direction. Thanks!
I see that the tests that are failing are mostly the ComputeService ones.

I'd propose to go step by step and merge the PR once it is ready (the objective of this PR
isn't to fix all tests, but to allow us to run all them at once), and fix the failing tests
in other PRs. WDYT?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/222#issuecomment-156250751
Mime
View raw message