jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: svn commit: r1206864 - /jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
Date Mon, 28 Nov 2011 07:17:20 GMT
I found the issue working on copy - paste patch That was submitted .
And yes tests are not capturing these issues ( same for synctimer non
transient barrierwrapper i fixed). This is because non
transient fields are not initialized in tests runs I think.

Regards
Philippe
On Monday, November 28, 2011, sebb <sebbaz@gmail.com> wrote:
> On 27 November 2011 22:09,  <pmouawad@apache.org> wrote:
>> Author: pmouawad
>> Date: Sun Nov 27 22:09:05 2011
>> New Revision: 1206864
>>
>> URL: http://svn.apache.org/viewvc?rev=1206864&view=rev
>> Log:
>> Make field volatile to ensure Serializable contract
>
> [I think you meant transient; it was already volatile.]
>
> Just wondering how you found this problem?
> And I wonder why the serialisation tests did not find it.
>
>> Modified:
>>
 jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
>>
>> Modified:
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
>> URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java?rev=1206864&r1=1206863&r2=1206864&view=diff
>>
==============================================================================
>> ---
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
(original)
>> +++
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
Sun Nov 27 22:09:05 2011
>> @@ -48,7 +48,7 @@ public class BeanShellSampler extends Be
>>
>>     public static final String RESET_INTERPRETER =
"BeanShellSampler.resetInterpreter"; //$NON-NLS-1$
>>
>> -    private volatile BeanShellInterpreter savedBsh = null;
>> +    private transient volatile BeanShellInterpreter savedBsh = null;
>>
>>     @Override
>>     protected String getInitFileProperty() {
>>
>>
>>
>

-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message