jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <pmoua...@apache.org>
Subject Re: svn commit: r1211209 - in /jmeter/trunk: src/core/org/apache/jmeter/control/TransactionController.java xdocs/changes.xml
Date Tue, 06 Dec 2011 22:31:27 GMT
Hello Sebb, Milamber,
If you have time to look at this fix, if you think there can be issues with
it.
Tests run OK, but I am not sure there are many JUnit tests related to
ThroughputController.

Regards
Philippe

On Tue, Dec 6, 2011 at 11:28 PM, <pmouawad@apache.org> wrote:

> Author: pmouawad
> Date: Tue Dec  6 22:28:51 2011
> New Revision: 1211209
>
> URL: http://svn.apache.org/viewvc?rev=1211209&view=rev
> Log:
> Bug 52296 - Getting ERROR sampleEnd called twice java.lang.Throwable:
> Invalid call sequence
>
> Modified:
>
>  jmeter/trunk/src/core/org/apache/jmeter/control/TransactionController.java
>    jmeter/trunk/xdocs/changes.xml
>
> Modified:
> jmeter/trunk/src/core/org/apache/jmeter/control/TransactionController.java
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/control/TransactionController.java?rev=1211209&r1=1211208&r2=1211209&view=diff
>
> ==============================================================================
> ---
> jmeter/trunk/src/core/org/apache/jmeter/control/TransactionController.java
> (original)
> +++
> jmeter/trunk/src/core/org/apache/jmeter/control/TransactionController.java
> Tue Dec  6 22:28:51 2011
> @@ -170,7 +170,7 @@ public class TransactionController exten
>
>         Sampler returnValue = super.next();
>
> -        if (returnValue == null) // Must be the end of the controller
> +        if (returnValue == null && !(calls == 0)) // Must be the end of
> the controller
>         {
>             if (res != null) {
>                 res.setIdleTime(pauseTime+res.getIdleTime());
> @@ -186,6 +186,9 @@ public class TransactionController exten
>
>                 SamplePackage pack = (SamplePackage)
> threadVars.getObject(JMeterThread.PACKAGE_OBJECT);
>                 if (pack == null) {
> +                       // If child of TransactionController is a
> ThroughputController and TPC does
> +                       // not sample its children, then we will have this
> +                       // TODO Should this be at warn level ?
>                     log.warn("Could not fetch SamplePackage");
>                 } else {
>                     SampleEvent event = new SampleEvent(res,
> threadContext.getThreadGroup().getName(),threadVars, true);
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1211209&r1=1211208&r2=1211209&view=diff
>
> ==============================================================================
> --- jmeter/trunk/xdocs/changes.xml (original)
> +++ jmeter/trunk/xdocs/changes.xml Tue Dec  6 22:28:51 2011
> @@ -113,6 +113,7 @@ This behaviour can be changed with prope
>  <li>Bug 51865 - Infinite loop inside thread group does not work properly
> if "Start next loop after a Sample error" option set</li>
>  <li>Bug 51868 - A lot of exceptions in jmeter.log while using option
> "Start next loop" for thread</li>
>  <li>Bug 51866 - Counter under loop doesn't work properly if "Start next
> loop on error" option set for thread group</li>
> +<li>Bug 52296 - Getting ERROR sampleEnd called twice java.lang.Throwable:
> Invalid call sequence</li>
>  </ul>
>
>  <h3>Listeners</h3>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message