jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1212779 - /jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java
Date Sat, 10 Dec 2011 12:30:56 GMT
On 10 December 2011 12:17, Philippe Mouawad <philippe.mouawad@gmail.com> wrote:
> Is it the same as BatchLocalTest in build.xml ?

I meant create another test for the "batch_scripts" target.

> Sorry I commited before reading your message.

No problem, just test using JMeter 2.5.1 (might need to change
build.xml temporarilly) - or temporarily skip the call to
replaceContext()

Ideally every bug should have a test case that shows the bug.
We then fix the bug and the test case passes.

For trivial bugs that is probably unnecessary.
In this case, the bug definitely needs a test case; not least so any
regressions are detected.

> On Sat, Dec 10, 2011 at 1:12 PM, sebb <sebbaz@gmail.com> wrote:
>
>> On 10 December 2011 12:09,  <pmouawad@apache.org> wrote:
>> > Author: pmouawad
>> > Date: Sat Dec 10 12:09:18 2011
>> > New Revision: 1212779
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1212779&view=rev
>> > Log:
>> > Bug 52310 - variable in IPSource failed HTTP request if "Concurrent Pool
>> Size" is enabled
>> > ROLLBACK (Oups one modification passed)
>>
>> OK, before making any more changes, we need to add a test case for the
>> issue.
>> [E.g. a new batch test]
>> This will fail until the bug is fixed.
>>
>> > Modified:
>> >
>>  jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java
>> >
>> > Modified:
>> jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java?rev=1212779&r1=1212778&r2=1212779&view=diff
>> >
>> ==============================================================================
>> > ---
>> jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java
>> (original)
>> > +++
>> jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContextService.java
>> Sat Dec 10 12:09:18 2011
>> > @@ -48,14 +48,6 @@ public final class JMeterContextService
>> >     }
>> >
>> >     /**
>> > -     * Replace Thread Context by the parameter
>> > -     * @param context {@link JMeterContext}
>> > -     */
>> > -    public static void replaceContext(JMeterContext context) {
>> > -       threadContext.remove();
>> > -       threadContext.set(context);
>> > -    }
>> > -    /**
>> >      * Gives access to the current thread context.
>> >      *
>> >      * @return the current thread Context
>> >
>> >
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Mime
View raw message