jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: Issues 52618 and 52674
Date Sun, 26 Feb 2012 20:04:31 GMT
Hello,
I submitted a patch for
52674<https://issues.apache.org/bugzilla/show_bug.cgi?id=52674>
Hope you can have a look at it soon.

I didn't update Tests yet, if you think it's OK then I will update them.

Regards
Philippe

On Wed, Feb 15, 2012 at 11:30 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:

> Hello Sebb, Milamber, Rainer,
> Did you have time to look at:
>
>    - 52618 <https://issues.apache.org/bugzilla/show_bug.cgi?id=52618>
>
> Do you think patch should be applied ?
>
>
> Also I would like to have your opinion regarding :
>
>    - 52674 <https://issues.apache.org/bugzilla/show_bug.cgi?id=52674>
>
> I started an implementation, should I provide a patch or commit it
> directly ?
>
> My idea is the following:
>
>    - Either introduce 2 interfaces:
>
>
>    1. SamplerFactory with following method:
>          1. createSampler(String contentType) => Called in
>          HttpRequestHdr#getSampler()
>       2. SamplerCustomizer with following method:
>          1. customizeSampler(HttpSamplerBase sampler) => Called in
>          HttpRequestHdr#getSampler()
>          2. fillBody(byte[] rawPostBody) => Called in
>          HttpRequestHdr#getSampler()
>
>
>    - Or introduce only one SamplerProvider:
>       - createSampler(String contentType) => Called in
>       HttpRequestHdr#getSampler()
>       - customizeSampler(HttpSamplerBase sampler) => Called in
>       HttpRequestHdr#getSampler()
>       - fillBody(byte[] rawPostBody) => Called in
>       HttpRequestHdr#getSampler():
>          - Default implementation would do what is done today inside if
>          ((!HTTPConstants.CONNECT.equals(getMethod())) && (!HTTPConstants.
>          GET.equals(method))) {
>          - Other protocols would handle it another way
>
> --
> Regards.
> Philippe Mouawad.
>
>
>
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message