jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: SaveService : Thread counts saving should be enabled by default
Date Sun, 06 Apr 2014 21:56:16 GMT
Thanks.
It will change results file.
I will document the change, it seems really required to me for lot of
plugins and for core as having the number of running vUs is critical info.

Regards
Philippe

On Sunday, April 6, 2014, sebb <sebbaz@gmail.com> wrote:

> On 6 April 2014 22:26, Philippe Mouawad <philippe.mouawad@gmail.com<javascript:;>>
> wrote:
> > Hello sebb,
> > Changing this value breaks many test case due to the fact that newly
> saved
> > XML for jmx will contain:
> > <threadCounts>true</threadCounts>
> >
> > Shall I change jmx test files or do you have an idea  ?
>
> testfiles/jmetertest.properties
>
> contains the property settings for unit tests.
>
> But are you sure that changing this won't break user tests?
>
> > Thanks
> >
> >
> > On Tue, Feb 11, 2014 at 2:44 AM, sebb <sebbaz@gmail.com <javascript:;>>
> wrote:
> >
> >> I expect it was omitted by default as the field was not present
> originally.
> >>
> >> If the default is changed, it needs to be documented as a
> >> (potentially) breaking change, as it may affect existing tests.
> >>
> >> On 9 February 2014 15:37, Shmuel Krakower <shmulikk@gmail.com<javascript:;>>
> wrote:
> >> > I also find it mandatory.
> >> > Up until now I override it with my user properties file and always
> copy
> >> > this file with every new release.
> >> >
> >> > www.beatsoo.org - free application performance monitoring from world
> >> wide
> >> > locations.
> >> > On Feb 9, 2014 5:24 PM, "Philippe Mouawad" <
> philippe.mouawad@gmail.com <javascript:;>>
> >> > wrote:
> >> >
> >> >> Hello,
> >> >> It seems to me strange that in default config thread counts is not
> >> output
> >> >> in results:
> >> >> #jmeter.save.saveservice.thread_counts=false
> >> >>
> >> >> This value which usually represents the number of Virtual Users seems
> >> to me
> >> >> a mandatory value in every test. I don't remember not setting it to
> >> true in
> >> >> all tests I made.
> >> >>
> >> >> Would you be OK to change default value to true ?
> >> >>
> >> >>
> >> >> Regards
> >> >> Philippe
> >> >>
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message