jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: svn commit: r1664885 - /jmeter/trunk/xdocs/css/new-style.css
Date Thu, 12 Mar 2015 21:19:11 GMT
Am 12.03.2015 um 21:03 schrieb Felix Schumacher:
> Am 10.03.2015 um 22:18 schrieb Philippe Mouawad:
>> On Tue, Mar 10, 2015 at 8:18 PM, sebb <sebbaz@gmail.com> wrote:
>>
>>> On 10 March 2015 at 18:07, Felix Schumacher
>>> <felix.schumacher@internetallee.de> wrote:
>>>> Am 08.03.2015 um 13:47 schrieb sebb:
>>>>
>>>>> On 8 March 2015 at 09:07, Felix Schumacher
>>>>> <felix.schumacher@internetallee.de> wrote:
>>>>>> Am 08.03.2015 um 00:26 schrieb sebb:
>>>>>>> On 7 March 2015 at 17:50, Felix Schumacher
>>>>>>> <felix.schumacher@internetallee.de> wrote:
>>>>>>>> Am 07.03.2015 um 18:37 schrieb sebb:
>>>>>>>>> On 7 March 2015 at 16:24, <fschumacher@apache.org>
wrote:
>>>>>>>>>> Author: fschumacher
>>>>>>>>>> Date: Sat Mar  7 16:24:00 2015
>>>>>>>>>> New Revision: 1664885
>>>>>>>>>>
>>>>>>>>>> URL: http://svn.apache.org/r1664885
>>>>>>>>>> Log:
>>>>>>>>>> Try to make the header as small as possible. It could
be that 
>>>>>>>>>> the
>>>>>>>>>> apache
>>>>>>>>>> ad will get cut off, if the ad uses the full height
>>>>>>>>> There are other sizes of ad, for example
>>>>>>>>>
>>>>>>>>> http://www.apache.org/ads/ApacheCon/2015-na-234x60.png
>>>>>>>>>
>>>>>>>>> The 125x125 one was originally chosen for the LHS menu
because 
>>>>>>>>> it is
>>>>>>>>> more suitable for that orientation.
>>>>>>>> I have put the bannerbar.html into the test pages at
>>>>>>>> p.a.o/~fschumacher/jmeter
>>>>>>>> While it makes the header use less height, it seems to be

>>>>>>>> problematic
>>>>>>>> on
>>>>>>>> small devices.
>>>>>>> Is it worse on small devices than banner.html?
>>>>>>> If so, why is that?
>>>>>> The square one would fit in a half wide div. The wide one would 
>>>>>> stand
>>> out
>>>>>> at
>>>>>> the right end and make the page seems bigger, which leads to a
>>> scrollable
>>>>>> page.
>>>>> Only on quite narrow devices.
>>>> Well, I can live with the result now. I hope to get the menu a bit
>>> smaller
>>>> still (on these narrow devices).
>>>>
>>>>>>> And does it really matter if smaller devices don't display well
-
>>>>>>> there's generally too much content anyway.
>>>>>> The content is generally ok. But the component reference is 
>>>>>> obviously a
>>>>>> large beast. I think generally we should aim to include small 
>>>>>> devices
>>> on
>>>>>> any
>>>>>> webpage we provide.
>>>>> I meant that there is too much useful content to make it worth trying
>>>>> to read it on a small device.
>>>>> I did not mean that there is too much content for all devices.
>>>> I meant to split up the long pages (component_reference, really) into
>>>> smaller parts, not to throw content away.
>>>>
>>>> And I think the doc is quite readable on small devices now. But I 
>>>> may be
>>>> biased :)
>>>>
>>>>>>>> I could hide it there or switch to the banner.html.
>>>>>>> I don't think it makes sense to use the square logo on the header
>>>>>>> banner.
>>>>>>> It wastes space on every page.
>>>>>>>
>>>>>>> One could perhaps revert to using banner.html at the bottom of

>>>>>>> the LHS
>>>>>>> menu.
>>>>>> That menu gets converted to an top page menu on smaller screen 
>>>>>> sizes,
>>> so
>>>>>> I
>>>>>> thought that this is not an ideal place either.
>>>>>>
>>>>>>> Or even put the square logo in the LHS for small devices and
use 
>>>>>>> the
>>>>>>> rectangular logo in the main heading for larger devices.
>>>>>> I have made the twitter div to use one line on smaller devices and
>>>>>> snuggle
>>>>>> the wide ad below that. We waste a bit space on small devices 
>>>>>> now, but
>>> I
>>>>>> think, that is not a problem, since users will have to scroll 
>>>>>> anyway.
>>>>> I think there's still a slight issue with the balance of the page on
>>>>> normal devices.
>>>>>
>>>>> The LHS menu font looks too big to me in comparison with the body 
>>>>> text.
>>>> We could insert another break point for the design, so that the menu
>>> would
>>>> be placed above the content on medium devices. On such devices a
>>> horizontal
>>>> menu would be nice, I think.
>>>>
>>>> I don't think that the font for the menu should be made smaller. 
>>>> But it
>>>> would be possible to change the width/max-width settings of the two
>>> columns,
>>>> so that the LHS gets a bit smaller on narrow devices.
>>> The problem I have is that the LHS menu font looks too big compared
>>> with the body text.
>>> Is the menu text really more important than the body text? So why is it
>>> bigger?
>>> The menu is intended for navigation, not information.
>>>
>>> The large font means that the menu is taller than it needs to be, so
>>> requires more vertical scrolling.
>>> The width of the menu is fine, though of course if a smaller font were
>>> used it could perhaps be made narrower.
>>>
>>> As an experiment, here is my version of the site with the menu
>>> font-size reduced to 80%
>>>
>>> http://people.apache.org/~sebb/jmeter/index.html
>>>
>>> I also reduce the menu width; however there are some other widths that
>>> also need to be changed.
>>>
>>> I think my version has a better balance of font sizes between the menu
>>> and body text.
>>>
>>>
>> I agree. I find this version slightly better.
> What browser and os screen/browser resolution did you test on? On my 
> ubuntu laptop (1366x768 pixel, 15") the fonts from sebb's version look 
> to small to me. And my version has the same amount of text on the page 
> as sebb's version. The only difference here is the number of lines of 
> the navigation, which can be seen.
>
>
>> Although it is true that doc is readable on small devices now and I find
>> that current version is much better than older one.
>>
>> One thing that I find a bit weird currently is that you tend to touch
>> headers expecting for something to happen but nothing does.
> What do you mean? Are you looking at the small device menu (on top of 
> main content)? Touching the main menu (or hovering over them) should 
> definitely present you with the next menu level. I found, that 
> sometimes my touches were interpreted as "double touches" and I was 
> sent right to the link destination. There is obviously space to improve.
I have updated my version to include a medium sized device and set them 
up with a top menu instead of a lhs.

The links are now orange, it looks a bit nicer, than the standard color 
blue, but the contrast seems too low.

The header is probably too big for small/medium devices.

Felix
>
> Felix
>>
>>
>>
>>
>>>> Felix
>>>>
>>>>>
>>>>>> Regards
>>>>>>    Felix
>>>>>>
>>>>>>>> What do you think?
>>>>>>> It's not worth spending time worrying about making the site look

>>>>>>> good
>>>>>>> on smaller displays.
>>>>>>>
>>>>>>>>>> Modified:
>>>>>>>>>>         jmeter/trunk/xdocs/css/new-style.css
>>>>>>>>>>
>>>>>>>>>> Modified: jmeter/trunk/xdocs/css/new-style.css
>>>>>>>>>> URL:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/css/new-style.css?rev=1664885&r1=1664884&r2=1664885&view=diff

>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>> ==============================================================================

>>>
>>>>>>>>>> --- jmeter/trunk/xdocs/css/new-style.css (original)
>>>>>>>>>> +++ jmeter/trunk/xdocs/css/new-style.css Sat Mar
 7 16:24:00 
>>>>>>>>>> 2015
>>>>>>>>>> @@ -70,7 +70,11 @@ h1, h2, h3, h4, h5, .title {
>>>>>>>>>>
>>>>>>>>>>      .banner>iframe {
>>>>>>>>>>        width: 140px;
>>>>>>>>>> -  height: 140px;
>>>>>>>>>> +  height: 130px;
>>>>>>>>>> +}
>>>>>>>>>> +.banner>iframe>body {
>>>>>>>>>> +  margin: 0px;
>>>>>>>>>> +  padding: 0px;
>>>>>>>>>>      }
>>>>>>>>>>
>>>>>>>>>>      body {
>>>>>>>>>>
>>>>>>>>>>
>>
>>
>


Mime
View raw message