jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request: Refactoring of HTTPSamplerBase
Date Sun, 20 Mar 2016 11:32:17 GMT
Github user FSchumacher commented on the pull request:

    https://github.com/apache/jmeter/pull/131#issuecomment-198908905
  
    I applied all of your formatting, typo and boolean expression changes (I think). The change
of APPLIABLE to APPLICABLE seems correct, but that mistake is in all classes, that use this
word, so I left it.
    I wonder if we should deprecate the unused method, in favour of deleting it, since it
could be used by someone else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message