jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antonio Gomes Rodrigues <ra0...@gmail.com>
Subject Re: [GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
Date Fri, 11 Mar 2016 15:24:17 GMT
Hi Sebb,

In org.apache.jmeter.config.CSVDataSet class I have add in iterationStart
method

    public void iterationStart(LoopIterationEvent iterEvent) {
(Move)        String _fileName = getFilename();
(Add)        if (!_fileName.isEmpty()) {
            FileServer server = FileServer.getFileServer();

.....


(Add)        } else {
(Add)            log.error("No filename setup in CSV Data Set Config:
"+this.getName());
(Add)            throw new JMeterStopThreadException("No filename setup in
CSV Data Set Config: "+this.getName());
 (Add)       }

Have I use the right exception (JMeterStopThreadException) to stop the test
plan execution?

Antonio


Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
www.avast.com
<https://www.avast.com/fr-fr/lp-safe-emailing?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=OA-2109-A>
<#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

2016-03-11 14:50 GMT+01:00 sebb <sebbaz@gmail.com>:

> On 11 March 2016 at 13:25, Antonio Gomes Rodrigues <ra0077@gmail.com>
> wrote:
> > Hi,
> >
> > JMeter not skip the missing filename silently (like previously)
> >
> > But now instead of having an FileNotFoundException exception + stacktrace
> > we have a clear error message + JMeterStopThreadException
> >
> > It's more clear for end user
> >
> > Is it ok?
>
> It's rather difficult reviewing a patch to a patch.
> Is there a URL which shows the complete patch against JMeter trunk?
>
> > Antonio
> >
> >
> >
> > 2016-03-10 18:29 GMT+01:00 Antonio Gomes Rodrigues <ra0077@gmail.com>:
> >
> >> Ok
> >>
> >> And refactor it to have better log?
> >>
> >> Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
> >> www.avast.com
> >> <
> https://www.avast.com/fr-fr/lp-esg-fav?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=OA-2109-B
> >
> >> <#-1759352762_DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
> >>
> >> 2016-03-10 17:52 GMT+01:00 Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com>
> >> :
> >>
> >>> sebb>If there is a script file with a working CSV Dataset, and the
> >>> filename
> >>> sebb>is accidentally erased, I don't think it's a good idea to continue
> >>> sebb>with the test.
> >>>
> >>> +1
> >>>
> >>> Vladimir
> >>>
> >>
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message