jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antonio Gomes Rodrigues <ra0...@gmail.com>
Subject Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions
Date Thu, 17 Mar 2016 11:11:11 GMT
Hi,


Modification made and new commit provided

Do we have a checkstyle configuration or something like that to avoid waste
time (your time and mine) in how to code to JMeter?

Antonio

Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
www.avast.com
<https://www.avast.com/fr-fr/lp-esg-fav?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=OA-2109-B>
<#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

2016-03-17 12:02 GMT+01:00 vlsi <git@git.apache.org>:

> Github user vlsi commented on a diff in the pull request:
>
>     https://github.com/apache/jmeter/pull/167#discussion_r56486961
>
>     --- Diff: src/core/org/apache/jmeter/services/FileServer.java ---
>     @@ -428,7 +431,7 @@ private BufferedReader
> createBufferedReader(FileEntry fileEntry) throws IOExcept
>                  isr = new InputStreamReader(fis);
>              }
>              return new BufferedReader(isr);
>     -    }
>     +        }
>     --- End diff --
>
>     Would you avoid adding extra spaces?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message