jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antonio Gomes Rodrigues <ra0...@gmail.com>
Subject Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions
Date Fri, 25 Mar 2016 11:14:03 GMT
Hi all,

Anybody have the time to review it and merge it if it's ok?
If you think I need more work on this PR, I can do it

Thank
Antonio

2016-03-22 16:24 GMT+01:00 Antonio Gomes Rodrigues <ra0077@gmail.com>:

> Hi all,
>
> I would like to add new enhancements to CSV Data Set with new PR
>
> For this PR, is it ok or I need rework it to be integrated?
>
>
> Thank
> Antonio
>
> 2016-03-19 9:30 GMT+01:00 Antonio Gomes Rodrigues <ra0077@gmail.com>:
>
>> Hi all,
>>
>> Do I need to modify something to allow the PR be accepted?
>>
>> Thank
>> Antonio
>>
>> 2016-03-17 14:45 GMT+01:00 Antonio Gomes Rodrigues <ra0077@gmail.com>:
>>
>>> Hi,
>>>
>>> Unitary tests fixed
>>>
>>> Antonio
>>>
>>> Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
>>> www.avast.com
>>> <https://www.avast.com/fr-fr/lp-esg-fav?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=OA-2109-B>
>>> <#m_7294166784504206657_-5108386039962379889_6858209084203675670_DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>>>
>>> 2016-03-17 12:38 GMT+01:00 sebb <sebbaz@gmail.com>:
>>>
>>>> On 17 March 2016 at 11:20, Antonio Gomes Rodrigues <ra0077@gmail.com>
>>>> wrote:
>>>> > I will fix the unit test asap
>>>> >
>>>> > Can you provide the checkstyle configuration to run it in local before
>>>> > commit the change?
>>>>
>>>> It's in SVN.
>>>>
>>>> But as already noted it does not catch everything.
>>>>
>>>> The best is to follow the layout convention for the file that you are
>>>> working on.
>>>> This may vary between files (and certainly does for source file types).
>>>>
>>>> > Antonio
>>>> >
>>>> > Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
>>>> > www.avast.com
>>>> > <
>>>> https://www.avast.com/fr-fr/lp-esg-fav?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=OA-2109-B
>>>> >
>>>> > <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>>>> >
>>>> > 2016-03-17 12:15 GMT+01:00 Vladimir Sitnikov <
>>>> sitnikov.vladimir@gmail.com>:
>>>> >
>>>> >> Antonio>Do we have a checkstyle configuration or something like
that
>>>> >> to avoid waste
>>>> >> Antonio>time (your time and mine) in how to code to JMeter?
>>>> >>
>>>> >> There's a checkstyle (it is run as a part of Travis job), however
it
>>>> >> would never check 100% of the issues.
>>>> >> My "else branch swap" request was just to make sure the diff does
not
>>>> >> bring unintentional modifications.
>>>> >>
>>>> >> By the way, have you seen that Travis job fails? Any chances your
>>>> fix that?
>>>> >>
>>>> >> Vladimir
>>>> >>
>>>>
>>>
>>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message