jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: svn commit: r1733650 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java xdocs/changes.xml
Date Sun, 06 Mar 2016 17:54:06 GMT
Hi Felix,
No strong opinion on this from me.

Regards

On Sat, Mar 5, 2016 at 12:00 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
>
> Am 4. März 2016 21:42:20 MEZ, schrieb pmouawad@apache.org:
> >Author: pmouawad
> >Date: Fri Mar  4 20:42:20 2016
> >New Revision: 1733650
> >
> >URL: http://svn.apache.org/viewvc?rev=1733650&view=rev
> >Log:
> >Bug 59118 - Add comment in recorded think time by proxy recorder
> >#resolve #157
> >Bugzilla Id: 59118
> >
> >Modified:
>
> >jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
> >    jmeter/trunk/xdocs/changes.xml
> >
> >Modified:
>
> >jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
> >URL:
> >
> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java?rev=1733650&r1=1733649&r2=1733650&view=diff
>
> >==============================================================================
> >---
>
> >jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
> >(original)
> >+++
>
> >jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
> >Fri Mar  4 20:42:20 2016
> >@@ -932,6 +932,7 @@ public class ProxyControl extends Generi
> >                 if (template instanceof Timer) {
> >                    TestElement timer = (TestElement) template.clone();
> >                     try {
> >+
> >timer.setComment("Recorded:"+Long.toString(deltaT)+"ms");
>
> Is the Long#toString really necessary?
>
> Regards,
> Felix
>
> >                         replacer.undoReverseReplace(timer);
> >                         model.addComponent(timer, node);
> >                     } catch (InvalidVariableException
> >
> >Modified: jmeter/trunk/xdocs/changes.xml
> >URL:
> >
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1733650&r1=1733649&r2=1733650&view=diff
>
> >==============================================================================
> >--- jmeter/trunk/xdocs/changes.xml (original)
> >+++ jmeter/trunk/xdocs/changes.xml Fri Mar  4 20:42:20 2016
> >@@ -133,6 +133,7 @@ Summary
> ><li><bug>59060</bug>HTTP Request GUI : Move File Upload to a new
Tab to
> >have more space for parameters and prevent incoherent configuration.
> >Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
> ><li><bug>59103</bug>HTTP Request Java Implementation: Change default
> >"http.java.sampler.retries" to align it on HttpClient behaviour and
> >make it meaningful</li>
> ><li><bug>59083</bug>HTTP Request : Make Method field editable so
that
> >additional methods (Webdav) can be added easily</li>
> >+    <li><bug>59118</bug>Add comment in recorded think time by
proxy
> >recorder. Contributed by Antonio Gomes Rodrigues (ra0077 at
> >gmail.com)</li>
> > </ul>
> >
> > <h3>Other samplers</h3>
>
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message