jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
Date Thu, 10 Mar 2016 16:04:08 GMT
The same would then apply to most of the test elements.
For example, an HTTP Sampler without a hostname.
Etc. etc.

It does not make sense to allow this.

If you want to add incomplete test elements, add them to the WorkBench.
Don't clutter the Test Plan with incomplete items.

On 10 March 2016 at 07:07, Antonio Gomes Rodrigues <ra0077@gmail.com> wrote:
> Hi,
>
> In my opinion is 2 different things:
> No filename setup
> Missing file
>
> And need 2 different treatment
>
> The first like I have said, I can add a CSV Dataset to later.
> The second, it's an error in my script
>
> Antonio
>
>
> 2016-03-10 0:54 GMT+01:00 sebb <sebbaz@gmail.com>:
>
>> On 9 March 2016 at 22:01, ra0077 <git@git.apache.org> wrote:
>> > Github user ra0077 commented on the pull request:
>> >
>> >     https://github.com/apache/jmeter/pull/162#issuecomment-194528887
>> >
>> >     Hi Philippe,
>> >
>> >     I was training a colleague to JMeter and I have add a CSV DataSet to
>> use it later in the test plan.
>> >     I run the test to check it before fill the CSV DataSet and I have
>> this exception
>> >     And it's not the first time I have it (when I work wit people who
>> are not expert I like to add all the element I want he will use it without
>> fill all of them)
>> >
>> >     To answer your question, I add a CSV DataSet with empty file name to:
>> >       tell to someone to use it
>> >       use it later when my test plan will be checked
>> >
>> >     With my use, the test will not failed and stop but continue (maybe
>> with a warning like I have implemented)
>> >
>> >     In all cases the need to ckeck the log to see the exception to
>> understand why the script don't start is not a good solution
>>
>> -1
>>
>> The JMeter log file is vital for understanding failures; script
>> failures included.
>>
>> If there is a script file with a working CSV Dataset, and the filename
>> is accidentally erased, I don't think it's a good idea to continue
>> with the test.
>>
>> I don't see that a missing file name should be treated any different
>> from a missing file.
>>
>> >     Regards
>> >     Antonio
>> >
>> >
>> > ---
>> > If your project is set up for it, you can reply to this email and have
>> your
>> > reply appear on GitHub as well. If your project does not have this
>> feature
>> > enabled and wishes so, or if the feature is enabled but not working,
>> please
>> > contact infrastructure at infrastructure@apache.org or file a JIRA
>> ticket
>> > with INFRA.
>> > ---
>>

Mime
View raw message