jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: PR221 : Guava or concurrentlinkedhashmap or Caffeine after Java8 migration
Date Thu, 11 Aug 2016 05:32:02 GMT


Am 9. August 2016 07:42:39 MESZ, schrieb Philippe Mouawad <philippe.mouawad@gmail.com>:
>Hello,
>Any thoughts on this ?
>Regards
>
>On Wednesday, August 3, 2016, Philippe Mouawad
><philippe.mouawad@gmail.com>
>wrote:
>
>> Hello,
>>
>> We have a PR-221 which relies on Guava.
>>
>> There is a discussion on github on the dependency on guava.
>>
>> What do team members think about this:
>> - Should we introduce guava (which can be used for other things by
>the way
>> not only for this feature)
>> - Should we use https://github.com/ben-manes/concurrentlinkedhashmap
>> - Should we migrate to Java 8 and then use
>https://github.com/ben-manes/
>> caffeine

+1 after migration to java 8 (not before next year)

>>
>>
>>
>> I vote for guava + PR integration as :
>>
>>    - I see interesting things in Guava for JMeter even if we move to
>Java
>>    8:
>>       - cache
>>       - annotations
>>       - collections
>>       - ...

We already have the commons jars, which will probably overlap quite a lot with guava, is it
worth the switch? 

>>
>> Although it's a minor agurment, the PR is ready to go, it's not if we
>> select CLHM or caffeine.

I wouldn't worry too much about it. 

Regards, 
Felix 

>>
>>
>>
>>
>> --
>> Regards.
>> Philippe
>>


Mime
View raw message