jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: PR221 : Guava or concurrentlinkedhashmap or Caffeine after Java8 migration
Date Wed, 17 Aug 2016 18:18:28 GMT
Hello,
As a conclusion :
- Ok for Java 8 for the N+2 release
- No go for guava integration

@Vladimir, you were waiting for this thread to end, I think you're
now welcome to propose a new patch for the blocker issue of 3.1 related to
bad throughput due to Css parsing cache access concurrency

Regards
Philippe

On Friday, August 12, 2016, sebb <sebbaz@gmail.com> wrote:

> I'm OK with requiring Java 8.
>
> I don't think we should make Guava a required dependency.
>
> On 12 August 2016 at 21:06, Philippe Mouawad <philippe.mouawad@gmail.com
> <javascript:;>> wrote:
> > Hi,
> > Sebb, Milamber, Antonio,
> > any thoughts on this ?
> >
> >
> > Thanks
> >
> > On Thu, Aug 11, 2016 at 7:38 AM, Felix Schumacher <
> > felix.schumacher@internetallee.de <javascript:;>> wrote:
> >
> >>
> >>
> >> Am 9. August 2016 07:42:39 MESZ, schrieb Philippe Mouawad <
> >> philippe.mouawad@gmail.com <javascript:;>>:
> >> >Hello,
> >> >Any thoughts on this ?
> >>
> >> To widen the discussion :)
> >>
> >> What about adding a full blown cache like commons jcs (is it still
> alive?)
> >> or ehcache, etc.
> >>
> >> Felix
> >>
> >> >Regards
> >> >
> >> >On Wednesday, August 3, 2016, Philippe Mouawad
> >> ><philippe.mouawad@gmail.com <javascript:;>>
> >> >wrote:
> >> >
> >> >> Hello,
> >> >>
> >> >> We have a PR-221 which relies on Guava.
> >> >>
> >> >> There is a discussion on github on the dependency on guava.
> >> >>
> >> >> What do team members think about this:
> >> >> - Should we introduce guava (which can be used for other things by
> >> >the way
> >> >> not only for this feature)
> >> >> - Should we use https://github.com/ben-manes/concurrentlinkedhashmap
> >> >> - Should we migrate to Java 8 and then use
> >> >https://github.com/ben-manes/
> >> >> caffeine
> >> >>
> >> >>
> >> >>
> >> >> I vote for guava + PR integration as :
> >> >>
> >> >>    - I see interesting things in Guava for JMeter even if we move to
> >> >Java
> >> >>    8:
> >> >>       - cache
> >> >>       - annotations
> >> >>       - collections
> >> >>       - ...
> >> >>
> >> >> Although it's a minor agurment, the PR is ready to go, it's not if
we
> >> >> select CLHM or caffeine.
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Regards.
> >> >> Philippe
> >> >>
> >>
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message