jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1789193 - in /jmeter/trunk: bin/ src/core/org/apache/jmeter/report/config/ src/core/org/apache/jmeter/report/dashboard/ test/resources/ test/src/org/apache/jmeter/report/dashboard/ xdocs/ xdocs/usermanual/
Date Mon, 10 Apr 2017 10:58:27 GMT
On 28 March 2017 at 19:59,  <pmouawad@apache.org> wrote:
> Author: pmouawad
> Date: Tue Mar 28 18:59:34 2017
> New Revision: 1789193
>
> URL: http://svn.apache.org/viewvc?rev=1789193&view=rev
> Log:
> Bug 60112 - Report / Dashboard : Add ability to customize APDEX thresholds per Transaction
name
> Contributed by Stephane Leplus
> This closes #287
> Bugzilla Id: 60112
>
==============================================================================
> --- jmeter/trunk/test/src/org/apache/jmeter/report/dashboard/ApdexPerTransactionTest.java
(added)
> +++ jmeter/trunk/test/src/org/apache/jmeter/report/dashboard/ApdexPerTransactionTest.java
Tue Mar 28 18:59:34 2017
> @@ -0,0 +1,144 @@
> +       private static String getOptionalProperty(Props props,
> +            String key, Class clazz) {
> +        String property = getProperty(props, key, null, clazz);
> +        if (property != null) {
> +        }

What is the point of the previous statement?

> +        return property;
> +    }
> +
> +       private static String getProperty(Props props, String key,
> +            String defaultValue, Class clazz)

The clazz parameter is not used.
Why not?

If the parameter is not needed here, then it's also not needed by the
previous method.

> +             {
> +        String value = props.getValue(key);
> +        if (value == null) {
> +            return defaultValue;
> +        }
> +        return value;
> +    }
> +}
>

Note: this class is the one that fails on Windows.

Mime
View raw message