jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmouawad <...@git.apache.org>
Subject [GitHub] jmeter issue #344: Migrate JSON Path Assertion into JMeter core
Date Wed, 29 Nov 2017 17:42:17 GMT
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/344
  
    Hi @artem-fedorov ,
    Thanks for the PR
    Regarding build:
    - You might have to merge the trunk as I made a fix in JMS few minutes ago.
    
    Regarding PR itself:
    - Package for assertions is org.apache.jmeter.assertions , so I think you should move
the class to it
    - I don't see JUnit tests for JSONAssertion , only for GUI, am I missing something ? If
they are really missing it would be nice if you could add some possibly spock / groovy based
or Junit only
    
    Regards


---

Mime
View raw message