jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request #396: Fix to 62336
Date Sun, 26 Aug 2018 19:30:24 GMT
Github user FSchumacher commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/396#discussion_r212836472
  
    --- Diff: src/core/org/apache/jmeter/gui/MainFrame.java ---
    @@ -680,7 +683,15 @@ private void addQuickComponentHotkeys(JTree treevar) {
     
                 @Override
                 public void actionPerformed(ActionEvent actionEvent) {
    -                String propname = "gui.quick_" + actionEvent.getActionCommand();
    +                //Bug 62336
    +                AWTEvent current_event = EventQueue.getCurrentEvent();
    +                String key_text = "";
    +                if(current_event instanceof KeyEvent) {
    +                    KeyEvent key_event = (KeyEvent)current_event;
    +                    key_text = KeyEvent.getKeyText( key_event.getKeyCode() );
    --- End diff --
    
    Again a minor nit: No space needed after the opening and before the closing parenthesis
as this is a function call.
    And as above variable names should be written in camel case: `keyEvent` instead of `key_event`.


---

Mime
View raw message