jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: svn commit: r1839892 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HC4CookieHandler.java
Date Mon, 03 Sep 2018 06:11:33 GMT
Am 02.09.2018 22:04, schrieb pmouawad@apache.org:
> Author: pmouawad
> Date: Sun Sep  2 20:04:13 2018
> New Revision: 1839892
> 
> URL: http://svn.apache.org/viewvc?rev=1839892&view=rev
> Log:
> Fix regression introduced by commit r1839891
> 
> Modified:
> 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HC4CookieHandler.java
> 
> Modified:
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HC4CookieHandler.java
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HC4CookieHandler.java?rev=1839892&r1=1839891&r2=1839892&view=diff
> ==============================================================================
> ---
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HC4CookieHandler.java
> (original)
> +++
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HC4CookieHandler.java
> Sun Sep  2 20:04:13 2018
> @@ -137,6 +137,7 @@ public class HC4CookieHandler implements
>                          } catch (MalformedCookieException e) { //
> This means the cookie was wrong for the URL
>                              log.info("Not storing invalid cookie:
> <{}> for URL {} ({})",
>                                  cookieHeader, url, 
> e.getLocalizedMessage());
> +                            continue;

I think it would be nicer to keep the exception handling together as it 
was before r1839891. The only change I can see after these two changes 
is the reduced logging severity.
Did I miss something?

Regards,
  Felix

>                          }
>                      }
>                      Date expiryDate = cookie.getExpiryDate();

Mime
View raw message