jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request #435: Get rid of deprecated new instance calls
Date Tue, 27 Nov 2018 21:52:56 GMT
GitHub user FSchumacher opened a pull request:

    https://github.com/apache/jmeter/pull/435

    Get rid of deprecated new instance calls

    ## Description
    This basically is an update to #431 
    
    Get rid of calls to `Class#newInstance()` by replacing them with `Class#getDeclaredConstructor()#newInstance()`
    
    And while I edited the classes I cleaned them up a bit, when eclipse showed warnings.
I think those snippets should be committed separately, but I left them in here, so that they
can be discussed if necessary.
    
    ## Motivation and Context
    Java 9 deprecates Class#newInstance(). 
    
    ## How Has This Been Tested?
    Tests should run when github merges this for testing.
    
    ## Screenshots (if appropriate):
    
    ## Types of changes
    <!--- What types of changes does your code introduce? Delete as appropriate -->
    - cleanup
    
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
    - [x] My code follows the [code style][style-guide] of this project.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FSchumacher/jmeter get-rid-of-deprecated-newInstance-calls

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #435
    
----
commit 9dabe9afee1af634f731226caede65c2b1fcac74
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:11:02Z

    Use StringUtils.isNotBlank to make intent clearer

commit 5db20ea5a86fed37e3bb523df86bb48fceb69fe4
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:15:06Z

    Replace deprecated newInstance calls

commit 9ea1b7b469892bd761083f22da33183f06f53a97
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:16:09Z

    Use log format string

commit c21bbd2a0776dab9cf20e19b574a503cc7df7ffc
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:21:08Z

    Get rid of deprecated newInstance call

commit c4a32b8a92b63aacd23785f6c8292f0aeaf4a72d
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:25:45Z

    Get rid of deprecated newInstance call
    
    Clarify the thrown exceptions of the createThinkTime method, while we
    are here

commit 90ac82643bb8ceb56184c0037fac18eee1232d23
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:27:55Z

    Get rid of deprecated newInstance call

commit dc04575bf94388ccf1eaef3d88a82ced10643ed2
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:30:49Z

    Get rid of deprecated newInstance call

commit 99dfb4999d5528d087256c7b95edf26fd8402b9d
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:32:32Z

    Use log format strings

commit 632a30f999d70fc6436f6f9b6b46fa390f941175
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:35:34Z

    Simplify code.
    
    With the introduction of varargs this can be written simpler. We don't
    have to construct arrays here anymore.

commit 59646b49f1dc4d8c92b9691c957678dd688e583a
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:36:19Z

    Use Java conventions for names of parameters

commit 100bf933a31fa61e19b310f83d2d8ead5469a983
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:37:53Z

    Use StringUtils#isNotBlank to make intent clearer

commit 08413fb9a3c4730773cbff6eccbbdb5b262f33c3
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:40:46Z

    Get rid of deprecated newInstance call

commit f10891f630e1539c71f42b4ce786465a332c4e45
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:48:25Z

    Extract code to create BackendListenerClient from a classname

commit e4e23ed9e546eb85c7e258124142d4a54e0a73ff
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:56:51Z

    Extract code into private methods to make intent clearer

commit 78f08709d44f10ec2871ab4120f3b805fba4d021
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T19:59:23Z

    Use StringUtils.isNotBlank to make intent of code clearer

commit 2d41ba0abd738c02b9188136cfb4b04715698ce7
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:02:22Z

    Get rid of deprecated newInstance call

commit cc882dfb64d1f354ed6bfc4204271ccdee75229f
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:04:38Z

    Get rid of deprecated newInstance calls

commit 3e7030da36783fd140c3a3a7ba33ae4615c2b865
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:06:23Z

    Get rid of deprecated newInstance calls

commit ee0536082eadb703f97f304420dc4d18e5aaa1d8
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:07:07Z

    Use log string formats

commit d78b7c490611483d8717126c8f56279f7f2212ef
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:11:23Z

    Get rid of deprecated newInstance call

commit 39b104c6a31b22727b23faa7dcedeb56a8e2e4e1
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:12:49Z

    Get rid of deprecated newInstance call

commit 92530c4ae1e5d5755d2b5e4c988b8acf3bb3f380
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:14:20Z

    Get rid of deprecated newInstance call

commit 9f74643e9169748a045299e2cf4ee948d7ce9547
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:16:09Z

    Get rid of deprecated newInstance call

commit 3c8b2da161c058b4311ff27bfd1bb7a4baa124e3
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:19:55Z

    Get rid of deprecated newInstance call

commit d1173219a4fd6bdf749684129db0e16830d0e6ef
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:23:01Z

    Get rid of deprecated newInstance call

commit 27f114fc3218a6f15df84dd3c651e8fc1230ba9c
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:26:50Z

    Use log format strings

commit d5c50fce7afa4577f9f1b7cc8e8c18a361fb6cef
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:30:35Z

    Get rid of deprecated newInstance call

commit b77206ee1a65b6eac95d13e44c6b63eb2da98f87
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:31:57Z

    Get rid of deprecated newInstance call

commit af2aa52161db0980e426704ff9a931135402b8fc
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:34:21Z

    Get rid of deprecated newInstance call

commit f6ffad96bc07c452e11019f8cb22b59d4da05ae5
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-11-27T20:36:39Z

    Get rid of deprecated newInstance call

----


---

Mime
View raw message