jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on a change in pull request #583: WIP fix for bug https://bz.apache.org/bugzilla/show_bug.cgi?id=64253
Date Thu, 23 Apr 2020 16:10:30 GMT

vlsi commented on a change in pull request #583:
URL: https://github.com/apache/jmeter/pull/583#discussion_r413930059



##########
File path: src/protocol/mail/src/main/java/org/apache/jmeter/protocol/mail/sampler/MailReaderSampler.java
##########
@@ -170,6 +170,7 @@ public SampleResult sample(Entry e) {
                 if (isUseSSL() || isUseStartTLS()) {
                     props.setProperty(mailProp(serverProtocol, "ssl.socketFactory.class"),
TRUST_ALL_SOCKET_FACTORY);  // $NON-NLS-1$
                     props.setProperty(mailProp(serverProtocol, "ssl.socketFactory.fallback"),
FALSE);  // $NON-NLS-1$
+                    props.setProperty(mailProp(serverProtocol, "ssl.enable"), "true");

Review comment:
       Could you please move this out of `if (isTrustAllCerts()) {` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message