jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on pull request #581: UI improvements.
Date Mon, 27 Apr 2020 18:30:45 GMT

vlsi commented on pull request #581:
URL: https://github.com/apache/jmeter/pull/581#issuecomment-620156828


   @pmouawad , the issue here is different LaFs require slightly different approaches for
the UI.
   
   I think we should not merge the PR as is as it improves Darklaf UI at cost of making other
UIs worse.
   
   I see the following ways to proceed:
   a) Make Darklaf the primary UI, and de-support others.
   b) Factor border generation to a helper method, so there are two code paths: one for Darklaf,
and another for others. It could be like `if (laf_titled_pane_has_border)`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message