jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] FSchumacher commented on a change in pull request #557: Updated commons-collections to 4.4 (from 3.2.2)
Date Fri, 01 May 2020 12:07:52 GMT

FSchumacher commented on a change in pull request #557:
URL: https://github.com/apache/jmeter/pull/557#discussion_r418516086



##########
File path: src/components/src/main/java/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
##########
@@ -135,9 +135,9 @@ public ViewResultsFullVisualizer() {
         super();
         final int maxResults = JMeterUtils.getPropDefault("view.results.tree.max_results",
500);
         if (maxResults > 0) {
-            buffer = new CircularFifoBuffer(maxResults);
+            buffer = new CircularFifoQueue<>(maxResults);
         } else {
-            buffer = new UnboundedFifoBuffer();
+            buffer = new LinkedList<>();

Review comment:
       What is your preferred List here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message