jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on a change in pull request #590: Update groovy 3
Date Thu, 07 May 2020 18:29:21 GMT

vlsi commented on a change in pull request #590:
URL: https://github.com/apache/jmeter/pull/590#discussion_r421708211



##########
File path: src/bom/build.gradle.kts
##########
@@ -87,7 +87,13 @@ dependencies {
         apiv("javax.mail:mail")
         apiv("jcharts:jcharts")
         apiv("junit:junit", "junit4")
-        apiv("org.codehaus.groovy:groovy-all")
+        apiv("org.codehaus.groovy:groovy", "groovy")
+        apiv("org.codehaus.groovy:groovy-datetime", "groovy")
+        apiv("org.codehaus.groovy:groovy-jmx", "groovy")
+        apiv("org.codehaus.groovy:groovy-json", "groovy")
+        apiv("org.codehaus.groovy:groovy-jsr223", "groovy")
+        apiv("org.codehaus.groovy:groovy-sql", "groovy")
+        apiv("org.codehaus.groovy:groovy-templates", "groovy")

Review comment:
       Can you please use `org.codehaus.groovy:groovy-bom` instead?
   
   ```suggestion
           api(platform("org.codehaus.groovy:groovy-bom:${"groovy".v}"))
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message