jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] FSchumacher commented on a change in pull request #590: Update groovy 3
Date Thu, 07 May 2020 19:16:20 GMT

FSchumacher commented on a change in pull request #590:
URL: https://github.com/apache/jmeter/pull/590#discussion_r421734922



##########
File path: src/bom/build.gradle.kts
##########
@@ -87,7 +87,13 @@ dependencies {
         apiv("javax.mail:mail")
         apiv("jcharts:jcharts")
         apiv("junit:junit", "junit4")
-        apiv("org.codehaus.groovy:groovy-all")
+        apiv("org.codehaus.groovy:groovy", "groovy")
+        apiv("org.codehaus.groovy:groovy-datetime", "groovy")
+        apiv("org.codehaus.groovy:groovy-jmx", "groovy")
+        apiv("org.codehaus.groovy:groovy-json", "groovy")
+        apiv("org.codehaus.groovy:groovy-jsr223", "groovy")
+        apiv("org.codehaus.groovy:groovy-sql", "groovy")
+        apiv("org.codehaus.groovy:groovy-templates", "groovy")

Review comment:
       That looks really nice, but when I try it out, it gives me the following error:
   ```
   Build jmeter FAILURE reason:                                
       org.gradle.internal.exceptions.LocationAwareException: Build file '/home/felix/Developer/fschumacher-jmeter/src/bom/build.gradle.kts'
line: 90
       Cannot convert the provided notation to an object of type DependencyConstraint: DefaultExternalModuleDependency{group='org.codehaus.groovy',
name='groovy-bom', version='3.0.3', configuration='default'}.
       The following types/formats are supported:
         - Instances of DependencyConstraint.
         - String or CharSequence values, for example 'org.gradle:gradle-core:1.0'.
         - Maps, for example [group: 'org.gradle', name: 'gradle-core', version: '1.0'].
         - Projects, for example project(':some:project:path').
         - Instances of ProjectDependency.
       
       Comprehensive documentation on dependency notations is available in DSL reference for
DependencyHandler type.
           Caused by: org.gradle.internal.typeconversion.UnsupportedNotationException: Cannot
convert the provided notation to an object of type DependencyConstraint: DefaultExternalModuleDependency{group='org.codehaus.groovy',
name='groovy-bom', version='3.0.3', configuration='default'}.
           The following types/formats are supported:
             - Instances of DependencyConstraint.
             - String or CharSequence values, for example 'org.gradle:gradle-core:1.0'.
             - Maps, for example [group: 'org.gradle', name: 'gradle-core', version: '1.0'].
             - Projects, for example project(':some:project:path').
             - Instances of ProjectDependency.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message