jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] FSchumacher commented on a change in pull request #612: Update README.md
Date Wed, 19 Aug 2020 13:35:00 GMT

FSchumacher commented on a change in pull request #612:
URL: https://github.com/apache/jmeter/pull/612#discussion_r473031551



##########
File path: README.md
##########
@@ -247,7 +247,7 @@ Export Administration Regulations, Section 740.13) for both object
 code and source code.
 
 The following provides more details on the included software that
-may be subject to export controls on cryptographic software:
+maybe subject to export controls on cryptographic software:

Review comment:
       I am pretty sure, that `may be` is correct here.

##########
File path: README.md
##########
@@ -79,7 +79,7 @@ Easy correlation through ability to extract data from most popular response
form
 - Several load statistics can be chosen with **pluggable tiers**.
 - Data analysis and **visualization plugins** allow great extensibility and personalization.
 - Functions can be used to provide dynamic input to a test or provide data manipulation.
-- Easy Continuous Integration via 3rd party Open Source libraries for Maven, Gradle and Jenkins.
+- Easy Continuous Integration via 3rd party Open Source libraries for Maven, Gradle, and
Jenkins.

Review comment:
       Have you had a look at all the other places, where we don't follow the rule to place
a comma before `and` when spelling out lists?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message