jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on a change in pull request #632: Add Error Prone code style verification
Date Sun, 18 Oct 2020 13:26:42 GMT

vlsi commented on a change in pull request #632:
URL: https://github.com/apache/jmeter/pull/632#discussion_r507149249



##########
File path: src/jorphan/src/main/java/org/apache/log/ContextMap.java
##########
@@ -53,7 +54,7 @@
     private final ContextMap m_parent;
 
     ///Container to hold map of elements
-    private Hashtable m_map = new Hashtable();
+    private HashMap<String, Object> m_map = new HashMap<>();

Review comment:
       `ContextMap` was marked as `@deprecated Will be dropped in 3.3`.
   Do we really need to investigate that?
   
   I might drop the class altogether if you like.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message