jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] ham1 commented on a change in pull request #632: Add Error Prone code style verification
Date Mon, 19 Oct 2020 07:51:15 GMT

ham1 commented on a change in pull request #632:
URL: https://github.com/apache/jmeter/pull/632#discussion_r507541080



##########
File path: src/components/src/main/java/org/apache/jmeter/assertions/XMLAssertion.java
##########
@@ -45,10 +48,12 @@
         @Override
         protected XMLReader initialValue() {
             try {
-                XMLReader reader = XMLReaderFactory.createXMLReader();
+                SAXParserFactory saxParserFactory = SAXParserFactory.newInstance();

Review comment:
       Do we need all the intermediary variables? e.g.
   ```
   XMLReader reader =
           SAXParserFactory.newInstance().newSAXParser().getXMLReader();
   ````




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message