jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on a change in pull request #632: Add Error Prone code style verification
Date Mon, 19 Oct 2020 08:39:49 GMT

vlsi commented on a change in pull request #632:
URL: https://github.com/apache/jmeter/pull/632#discussion_r507571249



##########
File path: extras/startup.bsh
##########
@@ -49,7 +48,7 @@ print(p + " = " + getprop(p));
 }
 
 loglevel(String priority, String category){
-LoggingManager.setPriority(priority, category);
+// TODO: implement?

Review comment:
       Pull requests are welcome.
   I have no idea what this code means, however, I am 100% sure the previous implementation
was doing absolutely nothing since `LogginManager.setPriority` was an empty method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message