jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] FSchumacher commented on pull request #632: Add Error Prone code style verification
Date Wed, 21 Oct 2020 09:20:07 GMT

FSchumacher commented on pull request #632:
URL: https://github.com/apache/jmeter/pull/632#issuecomment-713433154


   My biggest concern with this PR at the moment is its size. Could we add the feature (errorprone)
without changing every nag it shows? I tend to get bored when looking at big PRs and either
skip parts, or abort looking at it altogether.
   Apart from that, I am +1 on adding the feature (if it doesn't break the build when running
with Java 8). (Haven't tried it)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message