jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] woonsan opened a new pull request #631: BZ-64800: correcting plugin action components' resource key usages
Date Sun, 11 Oct 2020 16:37:45 GMT

woonsan opened a new pull request #631:
URL: https://github.com/apache/jmeter/pull/631


   ## Description
   <!--- Provide a general summary of your changes in the Title above -->
   <!--- Describe your changes in detail here -->
   
   ## Motivation and Context
   
   In the current version (v5.3), some child menu items under the tools fail to display translated
labels when switching to other languages or switching back to English again.
   
   Find more description in the issue ticket: https://bz.apache.org/bugzilla/show_bug.cgi?id=64800
   
   ## How Has This Been Tested?
   
   Clean build; confirm unit tests succeeded.
   And test the GUI menus manually while switching to French or Korean and back to English.
   
   ## Screenshots (if appropriate):
   
   Now translated menu labels are displayed when switching to French or Korean or back to
English, fixing the problem in the screenshot attachment in https://bz.apache.org/bugzilla/show_bug.cgi?id=64800.
   
   ## Types of changes
   
   - Bug fix (non-breaking change which fixes an issue)
   
   Even if the PR has some resource key changes, I don't think it breaks anything because:
   - Those submenus under the Tools have never been displayed correctly in v5.3, in French,
or even in English when switching it back to English.
   - Other language translations other than French have never had translated messages for
those 4 action menu items.
   - Therefore, changing the resource keys for those 4 actions in both Java code and those
existing resource files do not seem to break anything.
   
   ## Checklist:
   
   - [x] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message