jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] FSchumacher commented on a change in pull request #663: Bug 61805 - Allow simple HTTP request
Date Mon, 19 Apr 2021 15:33:58 GMT

FSchumacher commented on a change in pull request #663:
URL: https://github.com/apache/jmeter/pull/663#discussion_r615952741



##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
             </ul>
         ]]></description>
     </template>
+    <template isTestPlan="true">
+        <name>Simple HTTP request</name>
+        <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+        <description><![CDATA[
+        <h1>Template for simple HTTP request</h1>
+        <h2>JMeter Configuration</h2>
+        <p>Configure your HTTP request, set:
+            <ul>
+                <li>Full URL</li>
+                <li>Content Type</li>
+				<li>HTTP method</li>
+				<li>Body data</li>
+            </ul>
+        </p>
+        ]]></description>
+        <parameters>
+            <parameter defaultValue="https://jmeter.apache.org/" key="url"/>

Review comment:
       Maybe we should take another domain than our own, so no DOS will result ;) In the documentation
we use something ending on `example.invalid`. That way no one innocent will be harmed by the
default settings.

##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
             </ul>
         ]]></description>
     </template>
+    <template isTestPlan="true">
+        <name>Simple HTTP request</name>
+        <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+        <description><![CDATA[
+        <h1>Template for simple HTTP request</h1>
+        <h2>JMeter Configuration</h2>
+        <p>Configure your HTTP request, set:
+            <ul>
+                <li>Full URL</li>
+                <li>Content Type</li>
+				<li>HTTP method</li>

Review comment:
       Nobody will see it, but could you try to keep the spacepolice happy?

##########
File path: src/core/src/main/java/org/apache/jmeter/testelement/TestElement.java
##########
@@ -315,9 +315,9 @@
     String getName();
 
     /**
-     * Returns name of this element.
+     * Associates a name with this element.

Review comment:
       This seems to be left over from some other PR?

##########
File path: bin/templates/templates.xml
##########
@@ -251,4 +251,26 @@
             </ul>
         ]]></description>
     </template>
+    <template isTestPlan="true">
+        <name>Simple HTTP request</name>
+        <fileName>/bin/templates/simple-http-request-test-plan.jmx</fileName>
+        <description><![CDATA[
+        <h1>Template for simple HTTP request</h1>
+        <h2>JMeter Configuration</h2>
+        <p>Configure your HTTP request, set:
+            <ul>
+                <li>Full URL</li>
+                <li>Content Type</li>
+				<li>HTTP method</li>
+				<li>Body data</li>
+            </ul>
+        </p>
+        ]]></description>
+        <parameters>
+            <parameter defaultValue="https://jmeter.apache.org/" key="url"/>
+            <parameter defaultValue="application/json" key="contentType"/>
+            <parameter defaultValue="POST" key="method"/>
+	    <parameter defaultValue="" key="body"/>

Review comment:
       We need space ;)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message