jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] FSchumacher commented on pull request #660: bz65108: escape/unescape jmeter variable references
Date Sat, 24 Apr 2021 14:17:33 GMT

FSchumacher commented on pull request #660:
URL: https://github.com/apache/jmeter/pull/660#issuecomment-826099885


   I am not sure, that this is a better solution to not doing any JSON parsing at all.
   
   The problems arise (in my eyes) from the fact, that we re-used a sampler, that wasn't thought
for it and can't be used without change. One idea to modify it, was to add a listener/lifecycle-handler
interface to that specific sampler, where we could register a callback, that would get called
at the time the sampling gets done. There we could parse the JSON if needed. But that would
mean adding new interfaces and changes to the public interface of the sampler.
   
   The idea of checking the JSON at edit time, is probably doomed, as JMeter is too flexible.
A user could try to use the following code in the JSON value field: `${json_prefix} "abc":
42 ${json_suffix}` with `json_prefix={` and `json_suffix=}`. That would not be handled with
the proposed patch.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message