jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] mspangdal opened a new pull request #662: Setters in ConstantThroughputTimer need to set Properties to be picked up by test during runtime
Date Wed, 14 Apr 2021 17:21:17 GMT

mspangdal opened a new pull request #662:
URL: https://github.com/apache/jmeter/pull/662


   
   
   ## Description
   ConstantThroughputTimer setters doesnt register without setting Property like for other
elements like for example ThreadGroup
   
   So this makes the setters and getters of ConstantThroughputTimer use setProperty / getProperty
so users no longer have to run e.g. `constantThroughputTimer.setProperty("throughput", "300.5")`
but instead can use constantThroughputTimer.setThroughput(300.5) like intended(?)
   
   ## Motivation and Context
   See description
   
   ## How Has This Been Tested?
   <!--- Please describe in detail how you tested your changes. -->
   Probably should test more.  So far just throwing it out here since I noticed the problem
when trying to use the java api
   
   <!--- Include details of your testing environment, tests ran to see how -->
   verified the issue on macos and windows running jmeter programmatically in Java
   
   <!--- your change affects other areas of the code, etc. -->
   Not sure, would love some feedback of potential side effects.
   
   ## Screenshots (if appropriate):
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate -->
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
   - [ ] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message