johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [johnzon] rmannibucau commented on a change in pull request #62: Added possibility to use minus as array index for the remove operation.
Date Thu, 26 Mar 2020 06:18:48 GMT
rmannibucau commented on a change in pull request #62: Added possibility to use minus as array
index for the remove operation.
URL: https://github.com/apache/johnzon/pull/62#discussion_r398339170
 
 

 ##########
 File path: johnzon-core/src/main/java/org/apache/johnzon/core/JsonPointerImpl.java
 ##########
 @@ -339,8 +339,7 @@ private JsonValue getValue(JsonValue jsonValue, String referenceToken,
int curre
 
             try {
                 JsonArray jsonArray = (JsonArray) jsonValue;
-                int arrayIndex = Integer.parseInt(referenceToken);
-                validateArraySize(jsonArray, arrayIndex, jsonArray.size());
 
 Review comment:
   seems we loose that validation for number cases, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message