johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (Jira)" <j...@apache.org>
Subject [jira] [Commented] (JOHNZON-305) Johnzon should provide Java 9 module information
Date Thu, 19 Mar 2020 19:03:00 GMT

    [ https://issues.apache.org/jira/browse/JOHNZON-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062868#comment-17062868
] 

Romain Manni-Bucau commented on JOHNZON-305:
--------------------------------------------

Hi [~demonfiddler], we should add automatic module name (feel free to do a PR if you want
:)) but this does not prevent to use johnzon, the name will be derived form the jar name but
it works. We will likely not add module-info.class yet because it breaks too much of the Java
ecosystem compared to what it brings.

> Johnzon should provide Java 9 module information
> ------------------------------------------------
>
>                 Key: JOHNZON-305
>                 URL: https://issues.apache.org/jira/browse/JOHNZON-305
>             Project: Johnzon
>          Issue Type: Improvement
>          Components: Core, JAX-RS, JSON-B, Mapper, OSGi, Websocket
>    Affects Versions: 1.2.3
>            Reporter: Adrian Price
>            Priority: Major
>
> Johnzon does not declare any Java 9 modules and consequently it is not usable with a
modular Java 9+ program*. There are two possible approaches:
>  # Add module-info.java files to each of johnzon-core, johnzon-jaxrs, johnzon-jsonb,
johnzon-json-extras, johnzon-jsonschema, johnzon-mapper, johnzon-osgi, johnzon-websocket and
possibly johnzon-maven-plugin. (Preferred, the 'correct way'.)
>  # ConfigureĀ maven-jar-plugin with an archive/manifestEntries/Automatic-Module-Name
element. Probably best achieved with a plugin element in the parent /johnzon/pom.xml referencing
a property to be defined in each sub-module (say ${johnzon.module.name}). (Quick 'n dirty?)
> I'm not sure, but it might even be appropriate to do both... needs research.
> *You get exceptions like this: 'Unable to make field private final javafx.beans.property.BooleanProperty
io.github.demonfiddler.timer.model.MultiTimerBean.delayStart accessible: module io.github.demonfiddler.multitimer
does not "opens io.github.demonfiddler.timer.model" to unnamed module @22036d57'. Also Eclipse
problem markers like this: "Name of automatic module 'johnzon.core' is unstable, it is derived
from the module's file name."



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message