johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [johnzon] Neoklosch opened a new pull request #62: Added possibility to use minus as array index for the remove operation.
Date Fri, 20 Mar 2020 10:15:20 GMT
Neoklosch opened a new pull request #62: Added possibility to use minus as array index for
the remove operation.
URL: https://github.com/apache/johnzon/pull/62
 
 
   ## Problem
   
   Currently it is not allowed to remove an entry by using a `-` as array index.
   Since it is allowed for the add operation, it should also be allowed for all the other
operations.
   Further this is necessary if johnzon is used together with the JSON Patch library.
   
   ## Solution
   
   I've added a check for the `-` index in the `getArrayIndex` method to return the index
of the last entry.
   Additionally I've made the check in the `validateArrayIndex` more explicit.
   
   ## Test(s) added 
   
   One test that perform a remove with a `-` as array index.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message